feat(mobile): animate in-progress check status icons on the PR review page - #5875
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThis increment only drops leftover Files Reviewed (66 files)
Previous Review Summaries (6 snapshots, latest commit 419239e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 419239e)Status: No Issues Found | Recommendation: Merge Files Reviewed (87 files)
Previous review (commit 75f6a51)Status: 4 Issues Found | Recommendation: Address before merge Executive SummaryThis increment restores four unused namespaced catalog keys that mobile source already dropped in favor of Overview
Issue Details (click to expand)WARNING
Files Reviewed (87 files)
Fix these issues in Kilo Cloud Previous review (commit 8abc5f9)Status: No Issues Found | Recommendation: Merge Executive SummaryPending PR-check icons spin via SpinningIcon, Connect GitHub uses a fixed-size icon/spinner swap, tab screens reserve bar clearance with marginBottom, and catalog-key reuse matches existing patterns with high confidence. Files Reviewed (77 source files, 87 locale catalogs)
Previous review (commit 1c2839b)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental merge-conflict resolution for pending-check SpinningIcon plus mobile catalog-key reuse matches existing patterns with high confidence. Files Reviewed (77 source files, 87 locale catalogs)
Previous review (commit 380473a)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental changes (GitHub idle icon, tab-screen margin clearance, and tests) match existing mobile patterns with high confidence. Files Reviewed (4 files)
Previous review (commit a27ab3a)Status: No Issues Found | Recommendation: Merge Executive SummaryPending PR check icons now use SpinningIcon with spinning gated on pending tone; the change matches existing motion patterns with high confidence. Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 66.7K · Output: 8.1K · Cached: 365.1K Review guidance: REVIEW.md from base branch |
1c2839b to
8abc5f9
Compare
8abc5f9 to
75f6a51
Compare
184294e to
419239e
Compare
The comments are not a lint token. Restore t() call sites to plain keys.
Request
Changelog for users
Changelog for maintainers
SpinningIconwrapper (a Reanimated 1000 ms linear rotate loop that honorsuseReducedMotion), spinning only when the check tone ispending; completed, skipped, and warning icons stay static.GitHubIconand wraps the icon/spinner in a fixed-size container so the label does not shift when the connecting spinner appears; added a wiring test, and the tree helper now traverses all prop values instead of onlychildren.completedcheck status (queued, in_progress, pending, waiting, requested) and that no terminal status rotates. The tab-screen clearance change is shared by all tabbed screens, so check a list screen still scrolls above the tab bar.E2E proof
Recording of the verified flow (waits trimmed)
e1-ios-check-icons.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
e2-ios-no-layout-shift.mp4.trim.mp4
Follow-ups (not changed here)